Skip to content

Backport PR #34481 on branch 1.0.x (DOC: start 1.0.5) #34503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2020
Merged

Backport PR #34481 on branch 1.0.x (DOC: start 1.0.5) #34503

merged 1 commit into from
Jun 1, 2020

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #34481: DOC: start 1.0.5

@lumberbot-app lumberbot-app bot added this to the 1.0.5 milestone May 31, 2020
@jorisvandenbossche
Copy link
Member

cc @simonjayhawkins there are some failures on numpy dev build, like:

________ ERROR collecting pandas/tests/frame/indexing/test_indexing.py _________
pandas/tests/frame/indexing/test_indexing.py:31: in <module>
    class TestDataFrameIndexing:
pandas/tests/frame/indexing/test_indexing.py:80: in TestDataFrameIndexing
    DataFrame(columns=list("AB")),
pandas/core/frame.py:435: in __init__
    mgr = init_dict(data, index, columns, dtype=dtype)
pandas/core/internals/construction.py:239: in init_dict
    val = construct_1d_arraylike_from_scalar(np.nan, len(index), nan_dtype)
pandas/core/dtypes/cast.py:1440: in construct_1d_arraylike_from_scalar
    dtype = dtype.dtype
E   AttributeError: type object 'object' has no attribute 'dtype'

Did you already see that before?

But merging this, since it is unrelated to the whatsnew

@jorisvandenbossche jorisvandenbossche merged commit aec075b into pandas-dev:1.0.x Jun 1, 2020
@simonjayhawkins
Copy link
Member

Did you already see that before?

no, but I think should soon have a fix. This is not present on master, mainly down to the changes in #33725.

rather than try and backport all the changes in #33725, will raise a PR shortly with just the changes to fix CI on 1.0.x branch directly against the 1.0.x branch.

@simonjayhawkins simonjayhawkins mentioned this pull request Jun 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@meeseeksmachine @jorisvandenbossche @simonjayhawkins